-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimization hds and hp for system setups without hot water storage #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if no heating storage is implemented (Hp connected directly with hds) the massflow of hds system is calculated by hp model
… massflow and hot water storage some todos to fix and verification of constants
…t and thermal conductivity of screed and heat transfer screed to air
# Conflicts: # hisim/components/heat_distribution_system.py
- calculation of time constant if no massflow based on flexible parameters - add new parameters from hds model in system setups - fixing bug in hds tester
…t of hds model --> more flexible for future models
…nell zu finden zwischen ergebnis csv
…ot water storage --> connection heat pump to hds directly - adapt system setups and tests to "new" parameters from hds model and hp model - new system setup example for heating systems without hot water storage
- clean up hds config in system setups - additional usage of simple_hot_water_storage.py for system setup with storage in serie to hds and hp
…l storage --> water pump runs in both operation modes with constant massflow (checked with polysun simulation if operation modes are right) - some restructuring due to errors with mypy in combination with units and Quantity class
@noah80 @k-knosala |
- in some timestep dhw storage sends zero as input to dhw controller of hp - leads to more switching of hp between sh and dhw mode - solution: save last temperature input in dhw controller and if there will be a zero restore this temperature
- use hp output for calculating kpis --> now calculation without hot water storage possible
noah80
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional function for heating system setups without hot water storage.
Connection between HP and HDS directly.
Additional example and tests.